Allon Mureinik has posted comments on this change.

Change subject: core: ImportVm test cleanup: Use StringUtil.repeat
......................................................................


Patch Set 4: Do not submit

(1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
Line 80:         sd.setstorage_domain_type(StorageDomainType.Data);
Line 81:         sd.setstatus(StorageDomainStatus.Active);
Line 82:         sd.setavailable_disk_size(2);
Line 83:         return sd;
Line 84:     }
These two methods are a rebase foobar.
Will fix.
Line 85: 
Line 86:     @Test
Line 87:     public void testValidateNameSizeImportAsCloned() {
Line 88:         checkVmName(true, StringUtils.repeat("A", 300));


--
To view, visit http://gerrit.ovirt.org/9619
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f04e067e8bce2c6cd1010f83a44809a3c8c464c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to