Liron Aravot has posted comments on this change.
Change subject: core: Remove global lock on SPM calls from engine side
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 440: setmIrsPort(vds.getport());
Line 441: privatemCurrentIrsHost = vds.gethost_name();
Line 442: }
Line 443:
Line 444: public boolean failover(Guid currentCommandSpmId, Set<Guid>
mTriedVdssList) {
That's not wrong, that's a corner case which can happen as you dont have any
order, what's the probability? as each corner case/deadlock/race..low.
Line 445: synchronized (syncObj) {
Line 446: mTriedVdssList.add(currentCommandSpmId);
Line 447: if (currentCommandSpmId.equals(mCurrentVdsId)) {
Line 448: if (getHasVdssForSpmSelection(mCurrentVdsId,
mTriedVdssList)) {
Line 442: }
Line 443:
Line 444: public boolean failover(Guid currentCommandSpmId, Set<Guid>
mTriedVdssList) {
Line 445: synchronized (syncObj) {
Line 446: mTriedVdssList.add(currentCommandSpmId);
question - shouldn't mCurrentVdsId be volatile?
Line 447: if (currentCommandSpmId.equals(mCurrentVdsId)) {
Line 448: if (getHasVdssForSpmSelection(mCurrentVdsId,
mTriedVdssList)) {
Line 449: Guid vdsId = mCurrentVdsId;
Line 450: nullifyInternalProxies();
--
To view, visit http://gerrit.ovirt.org/9298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9779fa4b5a4da2ef3ca1d62fe5203a3949ce278
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
