Yair Zaslavsky has posted comments on this change.
Change subject: core: Remove global lock on SPM calls from engine side
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 457: if (getHasVdssForSpmSelection(mCurrentVdsId,
mTriedVdssList)) {
Line 458: Guid vdsId = mCurrentVdsId;
Line 459: nullifyInternalProxies();
Line 460: boolean performFailover = false;
Line 461: if (vdsId != null) {
Please remove this if...
Line 462: try {
Line 463: VDSReturnValue statusResult =
Line 464:
ResourceManager.getInstance().runVdsCommand(VDSCommandType.SpmStatus,
Line 465: new
SpmStatusVDSCommandParameters(vdsId, _storagePoolId));
--
To view, visit http://gerrit.ovirt.org/9298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9779fa4b5a4da2ef3ca1d62fe5203a3949ce278
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Daniel Paikov <pai...@gmail.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
