Maor Lipchuk has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
......................................................................
Patch Set 23: (14 inline comments)
....................................................
File backend/manager/dbscripts/vms_sp.sql
Line 470: AS $procedure$
Line 471: DECLARE
Line 472: curs CURSOR FOR SELECT vms.vm_guid FROM vm_static vms
Line 473: WHERE vms.vds_group_id IN (SELECT
vgs.vds_group_id FROM vds_groups vgs
Line 474: WHERE
vgs.storage_pool_id=v_storage_pool_id)
vgs might be misleading (virtual groups), maybe just use simply vds_groups
Line 475: ORDER BY vm_guid;
Line 476: id UUID;
Line 477: BEGIN
Line 478: OPEN curs;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java
Line 1: package org.ovirt.engine.core.bll;
formatter - Start comments with upper case
Line 2:
Line 3: import java.util.ArrayList;
Line 4: import java.util.HashMap;
Line 5: import java.util.LinkedList;
Line 91:
Line 92: updateOvfForVmsOfStoragePool(pool.getId());
Line 93:
Line 94: log.infoFormat("OvfDataUpdater: Successfully updated
VM OVFs in Data Center {0}",
Line 95: pool.getname());
"OvfDataUpdater:" is redundant here, we can conclude it from the class name
when the log will be printed.
Line 96: log.infoFormat("OvfDataUpdater: Attempting to update
template OVFs in Data Center {0}",
Line 97: pool.getname());
Line 98:
Line 99: updateOvfForTemplatesOfStoragePool(pool.getId());
Line 92: updateOvfForVmsOfStoragePool(pool.getId());
Line 93:
Line 94: log.infoFormat("OvfDataUpdater: Successfully updated
VM OVFs in Data Center {0}",
Line 95: pool.getname());
Line 96: log.infoFormat("OvfDataUpdater: Attempting to update
template OVFs in Data Center {0}",
same here
Line 97: pool.getname());
Line 98:
Line 99: updateOvfForTemplatesOfStoragePool(pool.getId());
Line 100:
Line 97: pool.getname());
Line 98:
Line 99: updateOvfForTemplatesOfStoragePool(pool.getId());
Line 100:
Line 101: log.infoFormat("OvfDataUpdater: Succesfully updated
templates OVFs in Data Center {0}",
same here for the redundant prefix
Line 102: pool.getname());
Line 103: log.infoFormat("OvfDataUpdater: Attempting to remove
uneeded template/vm OVFs in Data Center {0}",
Line 104: pool.getname());
Line 105:
Line 99: updateOvfForTemplatesOfStoragePool(pool.getId());
Line 100:
Line 101: log.infoFormat("OvfDataUpdater: Succesfully updated
templates OVFs in Data Center {0}",
Line 102: pool.getname());
Line 103: log.infoFormat("OvfDataUpdater: Attempting to remove
uneeded template/vm OVFs in Data Center {0}",
1) /s/uneeded/unneeded
2) redundant prefix of OvfDataUpdater:
Line 104: pool.getname());
Line 105:
Line 106:
removeOvfForTemplatesAndVmsOfStoragePool(pool.getId());
Line 107:
Line 104: pool.getname());
Line 105:
Line 106:
removeOvfForTemplatesAndVmsOfStoragePool(pool.getId());
Line 107:
Line 108: log.infoFormat("OvfDataUpdater: Succesfully removed
uneeded template/vm OVFs in Data Center {0}",
same here
Line 109: pool.getname());
Line 110: } catch (Exception ex) {
Line 111: addAuditLogError(pool.getname());
Line 112: log.errorFormat("Exception while trying to update
VMs/Templates ovf in Data Center {0}, the exception is {1}",
Line 356: return DbFacade.getInstance().getVmNetworkInterfaceDao();
Line 357: }
Line 358:
Line 359: protected VmAndTemplatesGenerationsDAO
getVmAndTemplatesGenerationsDao() {
Line 360: return
DbFacade.getInstance().getVmAndTemplatesGenerationsDAO();
/s/getVmAndTemplatesGenerationsDao/getVmAndTemplatesGenerationDAO
Line 361: }
Line 362:
Line 363: protected VmStaticDAO getVmStaticDao() {
Line 364: return DbFacade.getInstance().getVmStaticDao();
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
Line 234: return dbGeneration;
Line 235: }
Line 236:
Line 237: public void setDbGeneration(long db_generation) {
Line 238: this.dbGeneration = db_generation;
/s/db_generation/dbGeneration
Line 239: }
Line 240:
Line 241: public List<VmNetworkInterface> getInterfaces() {
Line 242: return interfaces;
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAO.java
Line 66: /**
Line 67: * @param userID
Line 68: * the ID of the user requesting the information
Line 69: * @param isFiltered
Line 70: * Whether the results should be filtered according to
the user's permissions
remove redundant parameters and please add general comment
Line 71: * @return The list of storage pool
Line 72: */
Line 73: List<storage_pool> getAllByStatus(StoragePoolStatus status);
Line 74:
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsDAO.java
Line 3: import java.util.List;
Line 4:
Line 5: import org.ovirt.engine.core.compat.Guid;
Line 6:
Line 7: public interface VmAndTemplatesGenerationsDAO extends DAO{
Please use formater on the interface
Line 8:
Line 9: /**
Line 10: * Updates the vms/templates ovf update version to the given value
Line 11: *
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java
Line 159: */
Line 160: public List<VM> getAllVmsRelatedToQuotaId(Guid quotaId);
Line 161:
Line 162:
Line 163: /** get all vms with the given ids
formatter
Line 164: * @param vmsIds
Line 165: * @return
Line 166: */
Line 167: public List<VM> getVmsByIds(List<Guid> vmsIds);
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAO.java
Line 91: List<VmTemplate> getAllTemplatesRelatedToQuotaId(Guid quotaId);
Line 92:
Line 93:
Line 94: /**
Line 95: * get all vm templates with the given ids
formatter, Upper case in first letter
Line 96: * @param templatesIds
Line 97: * @return
Line 98: */
Line 99: public List<VmTemplate> getVmTemplatesByIds(List<Guid>
templatesIds);
....................................................
Commit Message
Line 5: CommitDate: 2012-12-18 18:01:06 +0200
Line 6:
Line 7: core: introducing OvfAutoUpdate
Line 8:
Line 9: VM/template configurations (including disks info) are stored on the
/s/template/Template
Line 10: master storage domain for backup purposes and in order to provide the
Line 11: abillity to run VMs without having a running engine/db. Currently OVF
Line 12: update is done synchronously when performing various operations on
Line 13: VMs/templates - update, save, adding/removing a disk, etc. What's more,
--
To view, visit http://gerrit.ovirt.org/9328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca8
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
