Allon Mureinik has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
......................................................................
Patch Set 23: Looks good to me, but someone else must approve
(2 inline comments)
Generally speaking - looks OK.
There are some styling and documentation issues (see mlipchuk's and my own
comments inline).
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/OvfDataUpdaterTest.java
Line 251:
}).when(vmAndTemplatesGenerationsDAO).updateOvfGenerations(anyList(),
anyList());
Line 252: }
Line 253:
Line 254: private List<storage_pool> buildStoragePoolsList() {
Line 255: return Arrays.asList(pool1,pool2);
when you rebase, I'd add a space after the comma
Line 256: }
Line 257:
Line 258: private VM createVm(Guid id, VMStatus status) {
Line 259: VM vm = new VM();
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsDAO.java
Line 3: import java.util.List;
Line 4:
Line 5: import org.ovirt.engine.core.compat.Guid;
Line 6:
Line 7: public interface VmAndTemplatesGenerationsDAO extends DAO{
Don't think this should be part of /this/ patch
Line 8:
Line 9: /**
Line 10: * Updates the vms/templates ovf update version to the given value
Line 11: *
--
To view, visit http://gerrit.ovirt.org/9328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca8
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
