Eli Mesika has posted comments on this change. Change subject: engine: Fix SHD service not displaying issue (#885592) ......................................................................
Patch Set 2: (2 inline comments) .................................................... File backend/manager/dbscripts/gluster_volumes_sp.sql Line 109: BEGIN Line 110: RETURN QUERY SELECT * Line 111: FROM gluster_volumes Line 112: WHERE cluster_id = v_cluster_id AND status = v_status Line 113: AND vol_type IN (v_vol_types) How many types can be supported in this string, consider to change v_vol_types to text data type since the original length of 1 value is defined as 32 Line 114: AND id IN (SELECT volume_id FROM gluster_volume_options Line 115: WHERE option_key=v_option_key AND option_val=v_option_val); Line 116: END; $procedure$ Line 117: LANGUAGE plpgsql; Line 124: BEGIN Line 125: RETURN QUERY SELECT * Line 126: FROM gluster_volumes Line 127: WHERE cluster_id = v_cluster_id AND status = v_status Line 128: AND vol_type IN (v_vol_types); Same , see above Line 129: END; $procedure$ Line 130: LANGUAGE plpgsql; Line 131: Line 132: -- To view, visit http://gerrit.ovirt.org/10336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id11725f44ab3fdd36f76fe569d7610a411518ee1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <[email protected]> Gerrit-Reviewer: Dhandapani Gopal <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
