Eli Mesika has posted comments on this change.

Change subject: engine: Fix SHD service not displaying issue (#885592)
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File backend/manager/dbscripts/gluster_volumes_sp.sql
Line 109: BEGIN
Line 110:     RETURN QUERY SELECT *
Line 111:     FROM  gluster_volumes
Line 112:     WHERE cluster_id = v_cluster_id AND status = v_status
Line 113:     AND vol_type IN (v_vol_types)
Yes , it works , see sample on common_sp.sql :

-- Deletes a key from vdc_options by version/versions(comma separated)
create or replace FUNCTION fn_db_delete_config_for_version(v_version text)
returns void
AS $procedure$
BEGIN
     delete from vdc_options where version in (v_version);
END; $procedure$
LANGUAGE plpgsql;
Line 114:     AND id IN (SELECT volume_id FROM gluster_volume_options
Line 115:     WHERE option_key=v_option_key AND option_val=v_option_val);
Line 116: END; $procedure$
Line 117: LANGUAGE plpgsql;


--
To view, visit http://gerrit.ovirt.org/10336
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id11725f44ab3fdd36f76fe569d7610a411518ee1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to