Alon Bar-Lev has posted comments on this change.
Change subject: build: build rewrite using autotools
......................................................................
Patch Set 3: (4 inline comments)
....................................................
File ovirt-image-uploader.spec.in
Line 55: %doc AUTHORS
Line 56: %doc COPYING
Line 57: %config(noreplace) %{_sysconfdir}/ovirt-engine/imageuploader.conf
Line 58: %{python_sitelib}/ovirt_image_uploader/*.py*
Line 59: %{python_sitelib}/ovirt_image_uploader/ovf/*.py*
is that required?
Line 60: %{_bindir}/engine-image-uploader
Line 61: %{_mandir}/man8/*
Line 62:
Line 63: %changelog
....................................................
File src/ovf/Makefile.am
Line 27: common.xsd \
Line 28: ovf-environment.xsd \
Line 29: ovf-envelope.xsd \
Line 30: sample-ovf.xml \
Line 31: $(NULL)
shouldn't we install the above somewhere?
Line 32:
Line 33: ovfdir=$(ovirtimageuploaderlibdir)/ovf
Line 34: dist_ovf_PYTHON = \
Line 35: __init__.py \
Line 29: ovf-envelope.xsd \
Line 30: sample-ovf.xml \
Line 31: $(NULL)
Line 32:
Line 33: ovfdir=$(ovirtimageuploaderlibdir)/ovf
is that correct?
Line 34: dist_ovf_PYTHON = \
Line 35: __init__.py \
Line 36: ovfenvelope.py \
Line 37: ovfenvelopetest.py \
Line 34: dist_ovf_PYTHON = \
Line 35: __init__.py \
Line 36: ovfenvelope.py \
Line 37: ovfenvelopetest.py \
Line 38: $(NULL)
should we install these? and where?
Line 39:
Line 40: all-local: \
Line 41: python-syntax-check \
Line 42: $(NULL)
--
To view, visit http://gerrit.ovirt.org/11145
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2dabcd40a50e9ec19e796832d83fb9e89d5db24
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
