Keith Robertson has posted comments on this change. Change subject: build: build rewrite using autotools ......................................................................
Patch Set 5: (4 inline comments) Tried to answer all questions. LMK if you need more help Cheers .................................................... File src/ovf/Makefile.am Line 20: MAINTAINERCLEANFILES = \ Line 21: $(srcdir)/Makefile.in \ Line 22: $(NULL) Line 23: Line 24: EXTRA_DIST = \ No. Do not install these. For reference, the sum total of what needs to be installed is in the old RPM. As such, I would recommend you build the tools with my old makefile and then just do rpm -qpl on the generated RPM. This will ensure that you haven't left anything out. Line 25: CIM_ResourceAllocationSettingData.xsd \ Line 26: CIM_VirtualSystemSettingData.xsd \ Line 27: common.xsd \ Line 28: ovf-environment.xsd \ Line 20: MAINTAINERCLEANFILES = \ Line 21: $(srcdir)/Makefile.in \ Line 22: $(NULL) Line 23: Line 24: EXTRA_DIST = \ No. Do not install these. For reference, the sum total of what needs to be installed is in the old RPM. As such, I would recommend you build the tools with my old makefile and then just do rpm -qpl on the generated RPM. This will ensure that you haven't left anything out. Line 25: CIM_ResourceAllocationSettingData.xsd \ Line 26: CIM_VirtualSystemSettingData.xsd \ Line 27: common.xsd \ Line 28: ovf-environment.xsd \ Line 29: ovf-envelope.xsd \ Line 30: sample-ovf.xml \ Line 31: $(NULL) Line 32: Line 33: ovfdir=$(ovirtimageuploaderlibdir)/ovf See above. These are only files I use for testing. Line 34: dist_ovf_PYTHON = \ Line 35: __init__.py \ Line 36: ovfenvelope.py \ Line 37: ovfenvelopetest.py \ Line 30: sample-ovf.xml \ Line 31: $(NULL) Line 32: Line 33: ovfdir=$(ovirtimageuploaderlibdir)/ovf Line 34: dist_ovf_PYTHON = \ Yes. Here is what you need to install... [keith@whiplash ovirt-image-uploader] (master)$ rpm -qpl /home/keith/workspace-public-projects/ovirt-image-uploader/rpmtop/RPMS/noarch/ovirt-image-uploader-3.0.0-1.fc17.noarch.rpm /etc/ovirt-engine/imageuploader.conf /usr/bin/engine-image-uploader /usr/share/doc/ovirt-image-uploader-3.0.0 /usr/share/doc/ovirt-image-uploader-3.0.0/AUTHORS /usr/share/doc/ovirt-image-uploader-3.0.0/LICENSE /usr/share/man/man8/engine-image-uploader.8.gz /usr/share/ovirt-engine/image-uploader /usr/share/ovirt-engine/image-uploader/engine-image-uploader.py /usr/share/ovirt-engine/image-uploader/ovf /usr/share/ovirt-engine/image-uploader/ovf/__init__.py /usr/share/ovirt-engine/image-uploader/ovf/ovfenvelope.py Line 35: __init__.py \ Line 36: ovfenvelope.py \ Line 37: ovfenvelopetest.py \ Line 38: $(NULL) -- To view, visit http://gerrit.ovirt.org/11145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2dabcd40a50e9ec19e796832d83fb9e89d5db24 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
