Keith Robertson has posted comments on this change. Change subject: build: build rewrite using autotools ......................................................................
Patch Set 5: (1 inline comment) .................................................... File src/ovf/Makefile.am Line 30: sample-ovf.xml \ Line 31: $(NULL) Line 32: Line 33: ovfdir=$(ovirtimageuploaderlibdir)/ovf Line 34: dist_ovf_PYTHON = \ No. The OVF package is required. Here is the list of parts that must be shipped... --- /usr/share/ovirt-engine/image-uploader/ovf /usr/share/ovirt-engine/image-uploader/ovf/__init__.py /usr/share/ovirt-engine/image-uploader/ovf/ovfenvelope.py Line 35: __init__.py \ Line 36: ovfenvelope.py \ Line 37: ovfenvelopetest.py \ Line 38: $(NULL) -- To view, visit http://gerrit.ovirt.org/11145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2dabcd40a50e9ec19e796832d83fb9e89d5db24 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
