Michael Pasternak has posted comments on this change. Change subject: restapi: Add per-VM VncKeyboardLayout ......................................................................
Patch Set 4: I would prefer that you didn't submit this (2 inline comments) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 1977: <xs:element name="monitors" type="xs:int" minOccurs="0" maxOccurs="1"/> Line 1978: <xs:element name="allow_override" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1979: <xs:element ref="certificate" minOccurs="0" maxOccurs="1"/> Line 1980: <xs:element name="smartcard_enabled" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1981: <xs:element name="vnc_keyboard_layout" type="xs:string" minOccurs="0" maxOccurs="1"/> 1. formatting 2. why "vnc_keyboard_layout"? if we will support it in spice or in any other new client should we add "spice_keyboard_layout, "x_keyboard_layout" later? i suggest using "keyboard_layout" instead. Line 1982: </xs:sequence> Line 1983: </xs:complexType> Line 1984: Line 1985: <xs:complexType name="Ticket"> .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml Line 55: vm.display.monitors: xs:int Line 56: vm.display.type: xs:string Line 57: vm.display.allow_override: xs:boolean Line 58: vm.display.smartcard_enabled: xs:boolean Line 59: vm.display.vnc_keyboard_layout: xs:string can't see from the patch, but either vm.update or vm.add is missing Line 60: vm.os.cmdline: xs:string Line 61: vm.cpu.topology.cores: xs:int Line 62: vm.memory: xs:long Line 63: vm.high_availability.priority: xs:int -- To view, visit http://gerrit.ovirt.org/11315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdf2b9f74d483a1be9caaa6d6a47ba8de7c37420 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <[email protected]> Gerrit-Reviewer: Martin Beták <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
