Michael Pasternak has posted comments on this change. Change subject: restapi: Add per-VM VncKeyboardLayout ......................................................................
Patch Set 4: (1 inline comment) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 1977: <xs:element name="monitors" type="xs:int" minOccurs="0" maxOccurs="1"/> Line 1978: <xs:element name="allow_override" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1979: <xs:element ref="certificate" minOccurs="0" maxOccurs="1"/> Line 1980: <xs:element name="smartcard_enabled" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1981: <xs:element name="vnc_keyboard_layout" type="xs:string" minOccurs="0" maxOccurs="1"/> i do, 'vnc' prefix is not needed as we already in context of Display console, and the fact that in this stage it's only available for the vnc console, does not contradict the fact that in future we may support other console types (that may reuse keyboard_layout element) api is backward compatible interface, i don't want to keep for four versions deprecated stuff later, - api should use generic terminology (rather than type specific) Line 1982: </xs:sequence> Line 1983: </xs:complexType> Line 1984: Line 1985: <xs:complexType name="Ticket"> -- To view, visit http://gerrit.ovirt.org/11315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdf2b9f74d483a1be9caaa6d6a47ba8de7c37420 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Martin Beták <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
