Martin Beták has posted comments on this change. Change subject: restapi: Add per-VM VncKeyboardLayout ......................................................................
Patch Set 4: (1 inline comment) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 1977: <xs:element name="monitors" type="xs:int" minOccurs="0" maxOccurs="1"/> Line 1978: <xs:element name="allow_override" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1979: <xs:element ref="certificate" minOccurs="0" maxOccurs="1"/> Line 1980: <xs:element name="smartcard_enabled" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1981: <xs:element name="vnc_keyboard_layout" type="xs:string" minOccurs="0" maxOccurs="1"/> Are you sure with VNC being implementation detail? I would say that user knows he wants to set specifically the keyboard layout for VNC (because in spice he sets it via spice client). Calling it keyboard_layout would be IMHO confusing also because the name VncKeyboardLayout was already used throughout the backend when it was only settable via engine-config. Line 1982: </xs:sequence> Line 1983: </xs:complexType> Line 1984: Line 1985: <xs:complexType name="Ticket"> -- To view, visit http://gerrit.ovirt.org/11315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdf2b9f74d483a1be9caaa6d6a47ba8de7c37420 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Martin Beták <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
