Juan Hernandez has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
......................................................................
Patch Set 1: (6 inline comments)
....................................................
File backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
Line 46: <url-pattern>/engine.ssh.key.txt</url-pattern>
Line 47: <url-pattern>/rhevm.ssh.key.txt</url-pattern>
Line 48: </servlet-mapping>
Line 49:
Line 50: <!-- File servlet instance to serve spice/vnc descriptors -->
As far as I understand this servlet doesn't extend "FileServlet" so the comment
is a bit misleading. Can you improve it?
Line 51: <servlet>
Line 52: <servlet-name>ConsoleConfigServlet</servlet-name>
Line 53:
<servlet-class>org.ovirt.engine.core.console.ConsoleConfigServlet</servlet-class>
Line 54: <init-param>
Line 53:
<servlet-class>org.ovirt.engine.core.console.ConsoleConfigServlet</servlet-class>
Line 54: <init-param>
Line 55: <param-name>console-config-file</param-name>
Line 56: <param-value>console.config.template</param-value>
Line 57: </init-param>
I don't understand what is the purpose of this parameter, I don't see it used
anywhere. Can you explain?
Line 58: </servlet>
Line 59: <servlet-mapping>
Line 60: <servlet-name>ConsoleConfigServlet</servlet-name>
Line 61: <url-pattern>/console.config</url-pattern>
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/console/ConsoleConfigServlet.java
Line 37: response.setHeader("Expires", "Sat, 26 Jul 1997 05:00:00
GMT"); //disable caching HTTP/1.0
Line 38: }
Line 39:
Line 40: private void writeConfigFileHeader(HttpServletResponse response)
throws IOException {
Line 41: BufferedWriter writer = new BufferedWriter(new
OutputStreamWriter(response.getOutputStream()));
Try to use "response.getWriter()".
Line 42:
Line 43: writer.write(CONFIG_FILE_HEADER);
Line 44: writer.newLine();
Line 45: writer.flush();
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/IniServlet.java
Line 24:
Line 25: @Override
Line 26: protected void doGet(HttpServletRequest request,
HttpServletResponse response) throws ServletException, IOException {
Line 27: try {
Line 28: writeIniToStream(response.getOutputStream(),
request.getParameterMap());
I would suggest to use "response.getWriter()" ...
Also I don't understand why are you passing "request.getParameterMap()", that
means that you are echoing to the user all the parameters of the request. What
is the purpose of that?
Line 29: } catch (IOException e) {
Line 30: log.error("Error when writing to response stream " +
e.getMessage());
Line 31:
response.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
Line 32: }
Line 34:
Line 35: private void writeIniToStream(OutputStream out, Map<String,
String[]> dictionary)
Line 36: throws IOException
Line 37: {
Line 38: BufferedWriter writer = new BufferedWriter(new
OutputStreamWriter(out));
... and then avoid creating here a new BufferedWriter, as the output of the
request is already buffered by the application server.
Line 39:
Line 40: for (String key : dictionary.keySet()) {
Line 41: for (int i = 0; i < dictionary.get(key).length; i++) {
Line 42: StringBuilder builder = new StringBuilder();
Line 41: for (int i = 0; i < dictionary.get(key).length; i++) {
Line 42: StringBuilder builder = new StringBuilder();
Line 43:
builder.append(key).append("=").append(dictionary.get(key)[i]);
Line 44:
Line 45: writer.write(builder.toString());
Here instead of using a StringBuilder I would suggest to just do as many
"writer.print" calls as needed, as the output is already buffered.
Line 46: writer.newLine();
Line 47: }
Line 48: }
Line 49: writer.flush();
--
To view, visit http://gerrit.ovirt.org/11702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
