Roy Golan has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/console/ConsoleConfigServlet.java
Line 17: public class ConsoleConfigServlet extends IniServlet {
Line 18:
Line 19: private static final long serialVersionUID = 8496520437603585173L;
Line 20:
Line 21: private static final String CONFIG_FILE_HEADER = "[virt-viewer]";
so why not start with /usr/share/ovirt-engine/conf/ConsoleConfig.properties and
load it?
Line 22: private static final String HEADER_CONTENT_TYPE = "x-virt-viewer";
Line 23: private static final String HEADER_CONTENT_FILENAME = "console.vv";
Line 24:
Line 25: @Override
--
To view, visit http://gerrit.ovirt.org/11702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
