Frank Kobzik has posted comments on this change.

Change subject: core: Non-plugin automatic invocation of console session
......................................................................


Patch Set 1: (2 inline comments)

Thanks for comments.

....................................................
File backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
Line 46:     <url-pattern>/engine.ssh.key.txt</url-pattern>
Line 47:     <url-pattern>/rhevm.ssh.key.txt</url-pattern>
Line 48:   </servlet-mapping>
Line 49: 
Line 50:   <!-- File servlet instance to serve spice/vnc descriptors -->
right - forgot about changing the comment from the first implementation
Line 51:   <servlet>
Line 52:     <servlet-name>ConsoleConfigServlet</servlet-name>
Line 53:     
<servlet-class>org.ovirt.engine.core.console.ConsoleConfigServlet</servlet-class>
Line 54:     <init-param>


Line 53:     
<servlet-class>org.ovirt.engine.core.console.ConsoleConfigServlet</servlet-class>
Line 54:     <init-param>
Line 55:       <param-name>console-config-file</param-name>
Line 56:       <param-value>console.config.template</param-value>
Line 57:     </init-param>
..and the same for this.
Line 58:   </servlet>
Line 59:   <servlet-mapping>
Line 60:     <servlet-name>ConsoleConfigServlet</servlet-name>
Line 61:     <url-pattern>/console.config</url-pattern>


--
To view, visit http://gerrit.ovirt.org/11702
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to