Tal Nisan has posted comments on this change.
Change subject: core: DiskImage Hierarchy cleanup
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
Line 117: public Boolean getActive() {
Line 118: return getImage().isActive();
Line 119: }
Line 120:
Line 121: public void setActive(Boolean active) {
Think we can use boolean primitive here, the only place that sets it to the
wrapper type is in DiskImageDao
Line 122: getImage().setActive(Boolean.TRUE.equals(active));
Line 123: }
Line 124:
Line 125: @Override
Line 272: public ArrayList<String> getStoragesNames() {
Line 273: return storagesNames;
Line 274: }
Line 275:
Line 276: public void setStoragesNames(ArrayList<String> storagesNames) {
Think it can be change to the interface type, I don't like when methods receive
implementation types, List<String> will fit more here imo
Line 277: this.storagesNames = storagesNames;
Line 278: }
Line 279:
Line 280: @Deprecated
Line 277: this.storagesNames = storagesNames;
Line 278: }
Line 279:
Line 280: @Deprecated
Line 281: public Guid getimage_group_id() {
What about this method?
Line 282: return getId();
Line 283: }
Line 284:
Line 285: @Deprecated
--
To view, visit http://gerrit.ovirt.org/12051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf49ef042266187a6122ae4a667afd16d80efa52
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
