Tal Nisan has posted comments on this change.
Change subject: core: DiskImage Hierarchy cleanup
......................................................................
Patch Set 4: (4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
Line 75: setActive(active);
Line 76: setCreationDate(creation_date);
Line 77: setLastModifiedDate(last_modified_date);
Line 78: actualSizeFromDiskImageDynamic = actual_size;
Line 79: this.description = description;
setDescription will fit more, just like the others
Line 80: setImageId(image_guid);
Line 81: setImageTemplateGuid(it_guid);
Line 82: setSize(size);
Line 83: setParentId(parentId);
Line 116: return getImage().isActive();
Line 117: }
Line 118:
Line 119: public void setActive(boolean active) {
Line 120: getImage().setActive(true == active);
No need...
getImage().setActive(active)
Line 121: }
Line 122:
Line 123: @Override
Line 124: public Date getCreationDate() {
Line 212: return getImage().getTemplateImageId();
Line 213: }
Line 214:
Line 215: @Override
Line 216: public void setImageTemplateGuid(Guid guid) {
By the standard you applied throughout the class, it should be:
setImageTemplateId(Guid templateId)
Line 217: getImage().setTemplateImageId(guid);
Line 218: }
Line 219:
Line 220: public Guid getParentId() {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IImage.java
Line 18: void setDescription(String description);
Line 19:
Line 20: Guid getImageTemplateGuid();
Line 21:
Line 22: void setImageTemplateGuid(Guid value);
Same here
setImageTemplateId(Guid templateId)
Line 23:
Line 24: int getReadRateKbPerSec();
Line 25:
Line 26: void setReadRateKbPerSec(int readRate);
--
To view, visit http://gerrit.ovirt.org/12051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf49ef042266187a6122ae4a667afd16d80efa52
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
