Tal Nisan has posted comments on this change.
Change subject: core: DiskImage Hierarchy cleanup
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
Line 11: private static final long serialVersionUID = 1533416252250153306L;
Line 12:
Line 13: private Date lastModifiedDate;
Line 14: private ArrayList<String> storagesNames;
Line 15: // TODO comes from DiskImageDynamic
Do we still need those TODOs? Seem quite clear even without them
Line 16: private long actualSizeFromDiskImageDynamic;
Line 17: // TODO comes from DiskImageDynamic
Line 18: private int readRateFromDiskImageDynamic;
Line 19: // TODO comes from DiskImageDynamic
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IImage.java
Line 12: // DateTime lastmodified_date
Line 13: // {
Line 14: // get;
Line 15: // set;
Line 16: // }
This is legacy from the C# code, it can be removed
Line 17: long getSize();
Line 18:
Line 19: void setSize(long value);
Line 20:
Line 23: void setDescription(String value);
Line 24:
Line 25: Guid getItGuid();
Line 26:
Line 27: void setItGuid(Guid value);
Since you are refacoring, I'd give a more descriptive name to the
fields+getter/setter
Line 28:
Line 29: int getReadRateKbPerSec();
Line 30:
Line 31: void setReadRateKbPerSec(int value);
--
To view, visit http://gerrit.ovirt.org/12051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf49ef042266187a6122ae4a667afd16d80efa52
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
