Allon Mureinik has posted comments on this change.
Change subject: core: Remove image while VDSM returns not exist.
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(6 inline comments)
Please fix the grammer issues.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
Line 298: if (vdcReturnValue.getInternalTaskIdList().isEmpty())
{
Line 299: // We get here if we got
imageDoesNotExistsInDomain for the disk image from VDSM.
Line 300: endCommand();
Line 301: } else {
Line 302:
getReturnValue().getTaskIdList().addAll(vdcReturnValue.getInternalTaskIdList());
I'd do this regardless, and save the else block
Line 303: }
Line 304:
Line 305: }
Line 306: } else {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 83: VdcObjectType.Storage,
Line 84: getParameters().getStorageDomainId()));
Line 85: } catch (VdcBLLException e) {
Line 86: if (e.getErrorCode() ==
VdcBllErrors.ImageDoesNotExistInDomainError) {
Line 87: log.errorFormat("Image {0} does not exists in
domain {1}. Removing disk from DB only.",
s/exists/exist/
Line 88: getDiskImage().getId(),
Line 89: getParameters().getStorageDomainId());
Line 90: } else {
Line 91: throw e;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveTemplateSnapshotCommand.java
Line 46: setSucceeded(true);
Line 47: }
Line 48: } catch (VdcBLLException e) {
Line 49: if (e.getErrorCode() ==
VdcBllErrors.ImageDoesNotExistInDomainError) {
Line 50: log.errorFormat("Image {0} does not exists in domain
{1}. Removing disk from DB only.",
s/exists/exist/
Line 51: getDiskImage().getId(),
Line 52: getParameters().getStorageDomainId());
Line 53: } else {
Line 54: throw e;
....................................................
Commit Message
Line 3: AuthorDate: 2013-02-13 19:03:11 +0200
Line 4: Commit: Maor Lipchuk <[email protected]>
Line 5: CommitDate: 2013-02-14 17:56:55 +0200
Line 6:
Line 7: core: Remove image while VDSM returns not exist.
s/while/when/
Line 8:
Line 9: If image does not exists in the storage server, VDSM returns an
Line 10: exception at the initiating stage of the task.
Line 11: If engine encounter this exception it should avoid the exception print
a
Line 5: CommitDate: 2013-02-14 17:56:55 +0200
Line 6:
Line 7: core: Remove image while VDSM returns not exist.
Line 8:
Line 9: If image does not exists in the storage server, VDSM returns an
s/image/an image/
s/exists/exist/
s/storage server/storage domain/
Line 10: exception at the initiating stage of the task.
Line 11: If engine encounter this exception it should avoid the exception print
a
Line 12: log message and remove the disk any how from the DB.
Line 13:
Line 7: core: Remove image while VDSM returns not exist.
Line 8:
Line 9: If image does not exists in the storage server, VDSM returns an
Line 10: exception at the initiating stage of the task.
Line 11: If engine encounter this exception it should avoid the exception print
a
s/engine/the engine/
s/encounter/encounters/
s/print/printing/
Line 12: log message and remove the disk any how from the DB.
Line 13:
Line 14: Signed-off-by: Maor Lipchuk <[email protected]>
Line 15: Bug-Url: https://bugzilla.redhat.com/884635
--
To view, visit http://gerrit.ovirt.org/12077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36915c44e65e20e3ce222683650a562603e4bb05
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
