Michael Kublin has posted comments on this change.
Change subject: core: Remove image while VDSM returns not exist.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
Line 294: setLock(null);
Line 295: if (vdcReturnValue.getSucceeded()) {
Line 296: getParameters().getImagesParameters().add(p);
Line 297: setSucceeded(vdcReturnValue.getSucceeded());
Line 298: if (vdcReturnValue.getInternalTaskIdList().isEmpty())
{
Yes, and if task was not created why remove image?
Also, how these related to your comment : " // We get here if we got
imageDoesNotExistsInDomain for the disk image from VDSM" - comment is wrong ,
your action is wrong.
You should pass fault inside VdcReturnValue and based on fault decide how to
proceed, in such way you even not required to write comment because a flow
becomes obvious.
Line 299: // We get here if we got
imageDoesNotExistsInDomain for the disk image from VDSM.
Line 300: endCommand();
Line 301: } else {
Line 302:
getReturnValue().getTaskIdList().addAll(vdcReturnValue.getInternalTaskIdList());
--
To view, visit http://gerrit.ovirt.org/12077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36915c44e65e20e3ce222683650a562603e4bb05
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
