Ayal Baron has posted comments on this change. Change subject: engine: Removing opening of global transaction from endAction ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... Commit Message Line 16: should be only different updates of DB, no http calls, not locked section, no any other Line 17: "cool stuff" Line 18: The following patch can cause regression at some flows, so such flows should be fixed, Line 19: we can not stop and not to introduce changes which will improve all system, because we have Line 20: some bad flows, so such flow should be fixed. I don't see how this is ok. If you know you're breaking flows then make sure you fix them at the same time. Knowingly causing regressions is not acceptable imo. Line 21: This is a first step, a second is disable all global transactions Line 22: Line 23: Change-Id: Ic4c114d4d3072b8b9213d73cf8e155d98c5fbef6 -- To view, visit http://gerrit.ovirt.org/12010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c114d4d3072b8b9213d73cf8e155d98c5fbef6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
