Michael Kublin has posted comments on this change. Change subject: engine: Removing opening of global transaction from endAction ......................................................................
Patch Set 1: (1 inline comment) "commit the patches that fix the broken commands (one by one) , either in a top branch , or simply depend on it the previous patch commit all the changes together." - this should be done by relevant people, I will not do this alone. Also, like I said I don't know if some command is broken, appropriate people should provide a problematic command and fix it, by now that something is broken it is my own assumption. .................................................... Commit Message Line 16: should be only different updates of DB, no http calls, not locked section, no any other Line 17: "cool stuff" Line 18: The following patch can cause regression at some flows, so such flows should be fixed, Line 19: we can not stop and not to introduce changes which will improve all system, because we have Line 20: some bad flows, so such flow should be fixed. Ayal, please provide a flows which are broken? (That something is broken it is my assumption) If you can not please remove -1. We have two ways: 1. Keep old code, trying to solve a bugs by adding a workaround on workaround , and not perform any change because it can cause to regression. (It it similar to run on the same place - imo) 2. Perform a change and start to work in correct way, also if we will have a problem with some flow it is a good opportunity to fix it (This is move forward - imo) Also, I can not test all scenarios, so I am making assumption that possible something will not work. Now, philosophy question, I had a bug and someone add code on top on it, now if I will fix a bug added code will not work, so not to fix a bug? Line 21: This is a first step, a second is disable all global transactions Line 22: Line 23: Change-Id: Ic4c114d4d3072b8b9213d73cf8e155d98c5fbef6 -- To view, visit http://gerrit.ovirt.org/12010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c114d4d3072b8b9213d73cf8e155d98c5fbef6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
