Allon Mureinik has posted comments on this change. Change subject: engine: Removing opening of global transaction from endAction ......................................................................
Patch Set 1: I would prefer that you didn't submit this Following the discussion above. If an endSuccessfully or endWithFailure has more than one DAO call, by definition the behaviour changes - which most probably mean a regression. I don't agree, however, that this should be a series of patches - it will be hell to backport and/or review. Moreover, introducing another transaction in the endSuccessfully/endWithFailure methods before the global transaction is removed is a performance regression, and kind of defeats the point here. @Michael/Omer - I don't mind helping out here, let me know. The list of commands that should be handled: * RemoveDiskCommand * RemoveImageCommand * RemoveSnapshotCommand * RemoveVmTemplateCommand * RemoveVmTemplateFromImportExportCommand * MoveOrCopyTemplateCommand - should be handled carefully, non-trivial * ExportVmCommand - should be handled carefully, non-trivial * ImportVmCommand - should be handled carefully, non-trivial * MoveVmCommand - should be handled carefully, non-trivial * VmCommand - should be handled carefully, non-trivial * RunVmCommand - should be handled carefully, non-trivial * TryBackToAllSanpshotsOfVmCommand - should be handled * AddVmFromSnapshotCommand - should be handled carefully, * AddVmFromTemplateCommand - should be handled carefully, non-trivial * AttachUserToVmCommand - should be handled carefully, non-trivial * AddVmTemplateCommand - should be handled carefully, non-trivial * CreateImageTemplateCommand - should be handled carefully, non-trivial * CreateSnapshotCommand - should be handled carefully, non-trivial * CreateSnapshotFromTemplateCommand - should be handled carefully, non-trivial * AddImageFromScratchCommand - should be handled carefully, non-trivial * BaseImagesCommand - should be done carefully, there's a VDSM call smack in the middle * MoveOrCopyImageGroupCommand - should be done carefully, it called BaseImagesCommand.endSuccessfully * LiveMigrateDiskCommand - should be done carefully, it called BaseImagesCommand.endSuccessfully * HibernateVmCommand - should be done carefully, there's a VDSM call smack in the middle -- To view, visit http://gerrit.ovirt.org/12010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c114d4d3072b8b9213d73cf8e155d98c5fbef6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
