Alissa Bonas has posted comments on this change.
Change subject: core,restapi: Alias for registered disk
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java
Line 17:
Line 18: public class RegisterDiskCommand <T extends RegisterDiskParameters>
extends BaseImagesCommand<T> implements QuotaStorageDependent {
Line 19:
Line 20: private static final long serialVersionUID = -1201881996330878181L;
Line 21: private static final String DEFAULT_REGISTRATION_FORMAT =
"RegisteredDisk-%1$tY-%1$tm-%1$td-%1$tH-%1$tM-%1$tS";
yes, I also think using _ is more readable between sections. but no biggie...
Line 22:
Line 23: public RegisterDiskCommand(T parameters) {
Line 24: super(parameters);
Line 25:
setStorageDomainId(parameters.getDiskImage().getStorageIds().get(0));
Line 62: getReturnValue().setSucceeded(true);
Line 63: }
Line 64:
Line 65: protected static String getDefaultDiskAlias(Calendar time) {
Line 66: return String.format(DEFAULT_REGISTRATION_FORMAT, time);
IMHO it's a big confusing to have this method here , because there are already
methods in ImagesHandler that generate default aliases, so why isn't this one
also placed there?
Line 67: }
Line 68:
Line 69: @Override
Line 70: protected void setActionMessageParameters() {
--
To view, visit http://gerrit.ovirt.org/12565
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ab17da94ff7ff16852efb3a374148dacf1135f8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Chris Morrissey <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
