Michael Pasternak has posted comments on this change.
Change subject: core,restapi: Alias for registered disk
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResource.java
Line 57: GetUnregisteredDiskQueryParameters getDiskParams = new
GetUnregisteredDiskQueryParameters(
Line 58: asGuid(disk.getId()), storageDomainId,
getStoragePoolIdForDomain(storageDomainId));
Line 59: DiskImage unregisteredDisk = getEntity(DiskImage.class,
VdcQueryType.GetUnregisteredDisk, getDiskParams,
Line 60: disk.getId());
Line 61: unregisteredDisk.setDiskAlias(disk.getAlias());
this logic resides in the DiskMapper, you should be mapping new DiskImage
from the disk and using unregisteredDisk as a template.
by using mapper you make sure that all properties defined by user eventually
get in to the unregisteredDisk that will be send to the backend.
Line 62: RegisterDiskParameters registerDiskParams = new
RegisterDiskParameters(unregisteredDisk);
Line 63: return performCreate(VdcActionType.RegisterDisk,
registerDiskParams, ID_RESOLVER);
Line 64: } else {
Line 65: validateDiskForCreation(disk);
--
To view, visit http://gerrit.ovirt.org/12565
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ab17da94ff7ff16852efb3a374148dacf1135f8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Chris Morrissey <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
