Tal Nisan has posted comments on this change.
Change subject: core,restapi: Alias for registered disk
......................................................................
Patch Set 4: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RegisterDiskCommandTest.java
Line 18: calendar.set(Calendar.MINUTE, 34);
Line 19: calendar.set(Calendar.SECOND, 56);
Line 20:
Line 21: assertEquals("Wrong generated alias",
Line 22: "RegisteredDisk_1981-11-16_12-34-56",
Not sure, you can't compare the constant because it's a date format String so
you have to format the date, if you format the date and then compare, this
check is totally redundant...
Line 23:
RegisterDiskCommand.generateDefaultAliasForRegiteredDisk(calendar));
Line 24: }
--
To view, visit http://gerrit.ovirt.org/12565
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ab17da94ff7ff16852efb3a374148dacf1135f8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Chris Morrissey <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
