Gilad Chaplik has posted comments on this change. Change subject: userportal,webadmin: Builders infrastructure ......................................................................
Patch Set 9: I would prefer that you didn't submit this giving -1 since no one has replied my comment in engine devel: > * grouping several queries together, allowing to load data into a > dialog, for > example, in a single "bulk", rather than calling 20 different queries > (New VM dialog > and alike are the most painful - can take a lot of time to load, > especially on WAN). I think that all other issues are insignificant comparing to this one. If we invest the resources to refactor this area, this should be our primary goal. different approaches may lead us to have the same talk/cycle in the near future. I think that each of the items you've mentioned here is more than enough to postpone/delay/rethink the solution for this issue; maybe propose a quick POC instead of investing time in sth that could/may change soon. [FYI: I think that inheritance is the way to go, but on the servlet side... we should call a single query to fill out the entire dialog] -- To view, visit http://gerrit.ovirt.org/10874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If81d4c71f9feebd6ececb9a2be46b353383046de Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
