Tomas Jelinek has posted comments on this change. Change subject: userportal,webadmin: Builders infrastructure ......................................................................
Patch Set 9: Hi Gilad, sorry for not answering on engine-devel. I see a few problems there: 1: I don't think the server should be aware of what specific dialogs do we have on client hence should not have any inheritance like "UserPortalNewVmDataQuery" 2: The server should not contain presentation logic (e.g. this fields are hidden because the user should not see in this dialog the data centers which are down) 3: who would process the FE events like "data center changed"? Sending all the events to backend and get the new data would be slow and again, moving the FE responsibilities to BE. If FE would process it, than we would end up in the same we have now (e.g. OK, DC changed, I need the new cluster list from this DC etc). What do others think? -- To view, visit http://gerrit.ovirt.org/10874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If81d4c71f9feebd6ececb9a2be46b353383046de Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
