Gilad Chaplik has posted comments on this change. Change subject: userportal,webadmin: Builders infrastructure ......................................................................
Patch Set 9: 1) we can add a new method to the RpcService we have client logic there 'on server side', sth like getVmDialogData with no reference to the server. 2) see 1, I don't see a problem with that, it's like a uiQuery or ssp. 3) the code in the servlet will be sync -> no problem for place holders to 'start the query in the middle', i.e selected cluster is changed -> type=cluster, guid=clusterId are send with getVmDialogData. again, if we are considering refactoring, and there will be extended code-reviews on it + QE resources, I don't see why not have a complete solution, at least have a POC (POC like you did in builders). btw, I don't mind doing this POC :-) Thanks. -- To view, visit http://gerrit.ovirt.org/10874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If81d4c71f9feebd6ececb9a2be46b353383046de Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
