Michael Kublin has posted comments on this change.
Change subject: core: Remove image when VDSM returns not exist.
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 88:
getDiskImage().getStoragePoolId().getValue());
Line 89: } else {
Line 90: throw e;
Line 91: }
Line 92: }
I did not understand why approach is more elegant?
Also, the first sentence of answer it is +1, second sentence -1. Sum is zero?
Neutral opinion?
Restarts? Dummy task are not kept in DB. After such solution we will have
tasks in
DB , in memory and DB, and only in memory. The flow is too much simple today we
need additional complications?
All mechanisms of AsyncTaskManager are expect that task exist in host, solution
can not be full with out changes at AsyncTaskManager.
"and it will also mean we won't need to worry about any future complicated BLL
commands that use RemoveImage." - this is sounds very bad, additional special
implementation for one command. We will implement different solution for every
command?
Line 93: getReturnValue().getInternalTaskIdList().add(
Line 94: createTask(creationInfo,
Line 95: getParameters().getParentCommand(),
Line 96: VdcObjectType.Storage,
--
To view, visit http://gerrit.ovirt.org/12077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36915c44e65e20e3ce222683650a562603e4bb05
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
