Allon Mureinik has posted comments on this change.
Change subject: core: Remove image when VDSM returns not exist.
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
See inline comment - creating a failed tasks would be much better.
Giving a tentative -1 until this comment is either addressed or an explanation
to why it wrong is provided.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 88:
getDiskImage().getStoragePoolId().getValue());
Line 89: } else {
Line 90: throw e;
Line 91: }
Line 92: }
I agree with Maor. IMHO, this approach, of creating a dummy task is much more
elegant, and it will also mean we won't need to worry about any future
complicated BLL commands that use RemoveImage.
I do, however, dislike the reliance on AsyncTaskManager's implementation of
handling a new task that does not exist in VDSM.
If it's possible to create a task in "failed" state off the bat, it would be
considerably better.
Line 93: getReturnValue().getInternalTaskIdList().add(
Line 94: createTask(creationInfo,
Line 95: getParameters().getParentCommand(),
Line 96: VdcObjectType.Storage,
--
To view, visit http://gerrit.ovirt.org/12077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36915c44e65e20e3ce222683650a562603e4bb05
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
