Liron Ar has posted comments on this change.
Change subject: core: Remove image when VDSM returns not exist.
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 88:
getDiskImage().getStoragePoolId().getValue());
Line 89: } else {
Line 90: throw e;
Line 91: }
Line 92: }
I don't agree with the concept of this change - we rely on async task manager
implementation (as the task doesn't exist actually on vdsm), creating dummy
tasks, attempt to poll them, persisting unneeded information to the db (of the
tasks), perform unneeded operations..etc - the previous solution was more
complicated, but more correct IMO.
Line 93: getReturnValue().getInternalTaskIdList().add(
Line 94: createTask(creationInfo,
Line 95: getParameters().getParentCommand(),
Line 96: VdcObjectType.Storage,
--
To view, visit http://gerrit.ovirt.org/12077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36915c44e65e20e3ce222683650a562603e4bb05
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
