Omer Frenkel has posted comments on this change.
Change subject: gluster: added cluster level check
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
Line 785: public void refreshHeavyWeightData() {
Line 786: log.debug("Refreshing Gluster Data [heavyweight]");
Line 787:
Line 788: for (VDSGroup cluster : getClusterDao().getAll()) {
Line 789: if
(cluster.getcompatibility_version().compareTo(Version.v3_2) >= 0 &&
cluster.supportsGlusterService()) {
you should use configuration infrastructure for compatibility checks, rather
than hard-coding, please check out examples in FeatureSupported class
Line 790: try {
Line 791: refreshClusterHeavyWeightData(cluster);
Line 792: } catch (Exception e) {
Line 793: log.errorFormat("Error while refreshing Gluster
heavyweight data of cluster {0}!",
--
To view, visit http://gerrit.ovirt.org/12970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3944e8b1d8d82eb19643b99f606da2364d6b582
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
