Shireesh Anjal has posted comments on this change.
Change subject: gluster: added cluster level check
......................................................................
Patch Set 5: (1 inline comment)
Response to Omer's comment in-line.
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 131: select fn_db_add_config_value('GlusterRefreshHeavyWeight', 'false',
'3.0');
Line 132: select fn_db_add_config_value('GlusterRefreshHeavyWeight', 'false',
'3.1');
Line 133: select fn_db_add_config_value('GlusterRefreshRateLight', '5',
'general');
Line 134: select fn_db_add_config_value('GlusterRefreshRateHeavy', '300',
'general');
Line 135: select fn_db_add_config_value('GlusterSupport', 'false', '3.0');
So if we enable a new feature in 3.1, we keep adding it's entry in DB for 3.1,
3.2, 3.3, 3,4 and so on? I don't really like this. I think having the "default
value" as true (enabled), and one entry for 3.0 to disable it should be good
enough.
In general, I think that's a flaw with the idea of having true/false
configurations for feature-version combinations. Maybe we should just store
"supported from version" value as config, and have a >= check in code. I'll
send a new patch-set with this approach.
Line 136: select
fn_db_add_config_value('GlusterVolumeOptionGroupVirtValue','virt','general');
Line 137: select
fn_db_add_config_value('GlusterVolumeOptionOwnerUserVirtValue','36','general');
Line 138: select
fn_db_add_config_value('GlusterVolumeOptionOwnerGroupVirtValue','36','general');
Line 139:
--
To view, visit http://gerrit.ovirt.org/12970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3944e8b1d8d82eb19643b99f606da2364d6b582
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
