Kanagaraj M has posted comments on this change.
Change subject: engine: Enable gluster hook on cluster
......................................................................
Patch Set 10: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java
Line 84:
Line 85: VDSReturnValue retValue = pairResult.getSecond();
Line 86: if (retValue.getSucceeded()) {
Line 87: // update status in database
Line 88: updateServerHookStatusInDb(entity.getId(),
pairResult.getFirst().getId(), getNewStatus());
will the sync job takes care of adding entries to server_hooks table?
As the sync job runs for every hour, how about a new server which got added
after one execution of sync job but before the the user tries to enable a hook?
Line 89: } else {
Line 90: errors.add(retValue.getVdsError().getMessage());
Line 91: }
Line 92: }
Line 100: }
Line 101: //The intention was to enable hook. So we update the entity
with status enabled irrespective of errors
Line 102: entity.setStatus(getNewStatus());
Line 103: updateServerHookInDb(entity);
Line 104:
same comment as above
Line 105: }
Line 106:
Line 107:
Line 108: protected abstract VDSCommandType getStatusChangeVDSCommand();
--
To view, visit http://gerrit.ovirt.org/10906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc6f9c77393ebed2803ec2a1b295a09f61642c31
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
