Kanagaraj M has posted comments on this change.
Change subject: engine: Enable gluster hook on cluster
......................................................................
Patch Set 12: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java
Line 70: entity =
getGlusterHooksDao().getById(getParameters().getHookId(),true);
Line 71: List <VDS> servers =
getAllUpServers(getParameters().getClusterId());
Line 72: List<GlusterServerHook> serverHooks = entity.getServerHooks();
Line 73: if (serverHooks.size() != servers.size()) {
Line 74:
errors.add(VdcBllMessages.CLUSTER_ALL_SERVERS_NOT_UP.toString());
Does it mean the command will fail if one server is down?
Line 75: }
Line 76:
Line 77: List<Callable<Pair<VDS, VDSReturnValue>>> taskList = new
ArrayList<Callable<Pair<VDS, VDSReturnValue>>>();
Line 78: for (final VDS upServer : servers) {
Line 106: } else {
Line 107: // ignore already enabled/disabled errors.
Line 108: if
(!VdcBllErrors.GlusterHookAlreadyEnabled.equals(retValue.getVdsError().getCode()))
{
Line 109: errors.add(retValue.getVdsError().getMessage());
Line 110: }
Don't we need to insert/update the server_hook entries for the servers which
had the hook enabled (assume sync jobs not discovered it yet)?
Line 111: }
Line 112: }
Line 113:
Line 114: if (errors.size() > 0) {
--
To view, visit http://gerrit.ovirt.org/10906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc6f9c77393ebed2803ec2a1b295a09f61642c31
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
