Sahina Bose has posted comments on this change.
Change subject: engine: Enable gluster hook on cluster
......................................................................
Patch Set 15: (2 inline comments)
Thanks again! Will resubmit and hoping to cover all scenarios this time.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java
Line 109: if
(!VdcBllErrors.GlusterHookAlreadyEnabled.equals(retValue.getVdsError().getCode()))
{
Line 110: errors.add(retValue.getVdsError().getMessage());
Line 111: } else {
Line 112: //making sure the status in DB is updated (in
case sync job has not yet updated these)
Line 113: updateServerHookStatusInDb(entity.getId(),
pairResult.getFirst().getId(), getNewStatus());
Done
Line 114: }
Line 115: }
Line 116: }
Line 117:
Line 125: setSucceeded(false);
Line 126: }
Line 127: } else {
Line 128: setSucceeded(true);
Line 129: }
Done
Line 130: //The intention was to enable hook. So we update the entity
with status enabled irrespective of errors
Line 131: entity.setStatus(getNewStatus());
Line 132: updateHookInDb(entity);
Line 133:
--
To view, visit http://gerrit.ovirt.org/10906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc6f9c77393ebed2803ec2a1b295a09f61642c31
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
