Omer Frenkel has posted comments on this change.
Change subject: core: lock disks when migrating VMs
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
Line 299: }
Line 300: }
Line 301:
Line 302: @Override
Line 303: protected Map<String, Pair<String, String>> getSharedLocks() {
my only thought is if call to super.getSharedLocks() here not needed,
just in case we will later on add shared locks to run vm, as we are now
starting to use this mechanism more and more
Line 304: if (sharedLockMap == null) {
Line 305: List<Disk> disksToLock = getVmPluggedDisks();
Line 306: if (!disksToLock.isEmpty()) {
Line 307: sharedLockMap = new HashMap<String, Pair<String,
String>>(disksToLock.size());
--
To view, visit http://gerrit.ovirt.org/13263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9a335c3269400b355acd566c8f39e4a50fa237b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
