Arik Hadas has posted comments on this change.
Change subject: core: lock disks when migrating VMs
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
Line 305: List<Disk> disksToLock = getVmPluggedDisks();
Line 306: if (!disksToLock.isEmpty()) {
Line 307: sharedLockMap = new HashMap<String, Pair<String,
String>>(disksToLock.size());
Line 308: for (Disk disk : disksToLock) {
Line 309: sharedLockMap.put(disk.getId().toString(),
LockMessagesMatchUtil.DISK);
yes, for your scenario you're correct - you're depending on other error
messages that were attached to the locks that prevent you from acquire this
one. but now that you take these shared lock you might cause other commands to
fail because they won't be able to acquire their locks (the probability is low
because you don't take those locks for the whole command but still) - if you'll
attach an error message like "VM <vm_name> is being migrating" here then the
user will get better messages when locks cannot be acquire because of the locks
you take here
Line 310: }
Line 311: }
Line 312: }
Line 313: return sharedLockMap;
--
To view, visit http://gerrit.ovirt.org/13263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9a335c3269400b355acd566c8f39e4a50fa237b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
