Arik Hadas has posted comments on this change.
Change subject: core: lock disks when migrating VMs
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
Line 298: }
Line 299: }
Line 300:
Line 301: @Override
Line 302: protected Map<String, Pair<String, String>> getSharedLocks() {
where are the exclusive locks, that should prevent taking these locks in case
of live storage migration, are taken? neither LiveMigrateDiskCommand nor
MoveOrCopyDiskCommand are annotated with @LockIdNameAttribute
Line 303: List<Disk> disksToLock = getVmPluggedDisks();
Line 304: if (!disksToLock.isEmpty()) {
Line 305: Map<String, Pair<String, String>> sharedLockMap =
Line 306: new HashMap<String, Pair<String,
String>>(disksToLock.size());
--
To view, visit http://gerrit.ovirt.org/13263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9a335c3269400b355acd566c8f39e4a50fa237b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
