Michael Kublin has posted comments on this change.
Change subject: core: lock disks when migrating VMs
......................................................................
Patch Set 6: Fails; I would prefer that you didn't submit this
(2 inline comments)
No answer regards rerun, but at any case patch contains a bug, so it not
working, that's why -1 in verified also.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
Line 303: @Override
Line 304: protected Map<String, Pair<String, String>> getSharedLocks() {
Line 305: List<Disk> disksToLock = getVmPluggedDisks();
Line 306: if (!disksToLock.isEmpty()) {
Line 307: Map<String, Pair<String, String>> sharedLockMap =
Allon, please read javadoc for constructor of HashMap and change patch
accordingly.
Line 308: new HashMap<String, Pair<String,
String>>(disksToLock.size());
Line 309: for (Disk disk : disksToLock) {
Line 310: sharedLockMap.put(disk.getId().toString(),
Line 311:
LockMessagesMatchUtil.makeLockingPair(LockingGroup.DISK,
getDiskSharedLockMessage()));
Line 309: for (Disk disk : disksToLock) {
Line 310: sharedLockMap.put(disk.getId().toString(),
Line 311:
LockMessagesMatchUtil.makeLockingPair(LockingGroup.DISK,
getDiskSharedLockMessage()));
Line 312: }
Line 313: }
return value null? Always? Are you sure that you verified a patch?
Line 314: return null;
Line 315: }
Line 316:
Line 317: private String getDiskSharedLockMessage() {
--
To view, visit http://gerrit.ovirt.org/13263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9a335c3269400b355acd566c8f39e4a50fa237b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
