Michael Kublin has posted comments on this change. Change subject: core: lock disks when migrating VMs ......................................................................
Patch Set 5: Fails; I would prefer that you didn't submit this This patch will not work, that's why -1 in Fails. The purpose will not be achieved, lock will clean in the end of execute(), but migration did not finish, we still have rerun(), but like I said lock is released. Second, a new query is introduced but we still has VmHandler.getPluggedDisks() code duplicate for me, one should be removed. Code duplication reason for -1 in code review. -- To view, visit http://gerrit.ovirt.org/13263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9a335c3269400b355acd566c8f39e4a50fa237b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
