Allon Mureinik has posted comments on this change.
Change subject: engine: Do not add disk in snapshot preview
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
See comment about behavior inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
Line 99: final boolean isNotDuringSnapshot =
Line 100:
validate(getSnapshotsValidator().vmNotDuringSnapshot(getVmId())) &&
Line 101:
validate(getSnapshotsValidator().vmNotInPreview(getVmId()));
Line 102:
Line 103: if (isImageDisk && !isNotDuringSnapshot) {
According to this code, it as seems as though we can attach a LUN disk during a
snapshot.
I don't believe this is the correct behavior.
Line 104: return false;
Line 105: }
Line 106:
Line 107: if (getParameters().isPlugUnPlug()
--
To view, visit http://gerrit.ovirt.org/13327
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfde0540f1d77456ed1412b015a0963f4682039f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
