Omer Frenkel has posted comments on this change.
Change subject: engine: Do not add disk in snapshot preview
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 129: if (getDiskLunMapDao().getDiskIdByLunId(lun.getLUN_id()) !=
null) {
Line 130: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DISK_LUN_IS_ALREADY_IN_USE);
Line 131: }
Line 132:
Line 133: return
since it is possible to add disk (LUN as well) without vm ("floating") then
getVm() can be null here
Line 134:
validate(getSnapshotValidator().vmNotDuringSnapshot(getVmId())) &&
Line 135:
validate(getSnapshotValidator().vmNotInPreview(getVmId())) &&
Line 136: validate(new VmValidator(getVm()).vmNotLocked());
Line 137: }
--
To view, visit http://gerrit.ovirt.org/13327
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfde0540f1d77456ed1412b015a0963f4682039f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Libor Spevak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
