Liron Ar has posted comments on this change.
Change subject: engine: Do not add disk in snapshot preview
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 134: if (getVm() == null) {
Line 135: return true;
Line 136: }
Line 137:
Line 138: return
we have no the same code repeated in checkIfImageDiskCanBeAdded and in
checkIfLunDiskCanBeAdded, why not have it in one place?
possibly we can add a method that will indicate wether we can add device to the
vm so we will be able to use it in other commands as well instead of have it
repeated.
Line 139:
validate(getSnapshotValidator().vmNotDuringSnapshot(getVmId())) &&
Line 140:
validate(getSnapshotValidator().vmNotInPreview(getVmId())) &&
Line 141: validate(new VmValidator(getVm()).vmNotLocked());
Line 142: }
--
To view, visit http://gerrit.ovirt.org/13327
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfde0540f1d77456ed1412b015a0963f4682039f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Libor Spevak <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
