Omer Frenkel has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (1)
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
Line 14: vm.getVdsGroupCompatibilityVersion(),
Line 15: vm.getStaticData());
Line 16:
Line 17: if (!validationErrors.isEmpty()) {
Line 18: VmHandler.handleCustomPropertiesError(validationErrors,
messages);
why the handle method is left in vmHandler?
Line 19: return false;
Line 20: }
Line 21:
Line 22: return true;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
Line 262: runVmParams.getDestinationVdsId() :
vm.getDedicatedVmForVds(),
Line 263: true,
Line 264: new VdsFreeMemoryChecker(new
NonWaitingDelayer()));
Line 265:
Line 266: return getRunVmValidator().canRunVm(vm, messages) &&
i dont understand the canRunVm method in runVmValidator,
why not use getRunVmValidator().validateVmProperties(vm, messages) as done in
run vm?
Line 267: VmRunHandler.getInstance().canRunVm(vm,
Line 268: messages,
Line 269: runVmParams,
Line 270: vdsSelector,
--
To view, visit http://gerrit.ovirt.org/13397
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I60bbdb54d150878123968893c23169de253e1ba2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
