Arik Hadas has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (1)
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(2 inline comments)
2 minor comments
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 680: canRunVm(vm) &&
Line 681: validateNetworkInterfaces();
Line 682: if (!canDoAction) {
Line 683: return false;
Line 684: }
I don't know yet if you changed it in a later patch but you can make this
method more readable by removing the canDoAction field from those lines
(678-684) and use new field at line 688, you don't really need it because if
you got to 685 then it is true..
Line 685:
Line 686: // check for Vm Payload
Line 687: if (canDoAction && getParameters().getVmPayload() !=
null) {
Line 688: canDoAction =
checkPayload(getParameters().getVmPayload(),
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/vmproperties/VmPropertiesUtils.java
Line 28: public class VmPropertiesUtils {
Line 29:
Line 30: private static VmPropertiesUtils vmPropertiesUtils = null;
Line 31:
Line 32: public static VmPropertiesUtils getInstance() {
not critical but is it important to have lazy evaluation instead of initialize
it in the declaration statement?
Line 33: if (vmPropertiesUtils == null) {
Line 34: vmPropertiesUtils = new VmPropertiesUtils();
Line 35: }
Line 36: return vmPropertiesUtils;
--
To view, visit http://gerrit.ovirt.org/13397
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I60bbdb54d150878123968893c23169de253e1ba2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
