Shireesh Anjal has posted comments on this change.
Change subject: engine: Enable gluster hook on cluster
......................................................................
Patch Set 22: Looks good to me, approved
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java
Line 121: if (errors.size() > 0) {
Line 122: // conflict in status
Line 123: entity.addStatusConflict();
Line 124: handleVdsErrors(getAuditLogTypeValue(), errors);
Line 125: addCustomValue("FailureMessage" ,
StringUtils.join(errors, SystemUtils.LINE_SEPARATOR));
Minor: maybe add "FailureMessage" to GlusterConstants ?
Line 126: }
Line 127:
Line 128: //The intention was to enable/disable hook. So we update the
entity with new status if command succeeded
Line 129: if (getSucceeded()) {
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommandTest.java
Line 84:
when(hooksDao.getById(HOOK_ID,true)).thenReturn(getHookEntity());
Line 85: doReturn(hooksDao).when(cmd).getGlusterHooksDao();
Line 86: when(vdsGroupDao.get(CLUSTER_ID)).thenReturn(getVdsGroup());
Line 87: doReturn(vdsGroupDao).when(cmd).getVdsGroupDAO();
Line 88:
//doNothing().when(cmd).handleVdsErrors(any(AuditLogType.class),
any(ArrayList.class),any(Boolean.class));
Minor: remove this commented line?
Line 89: doReturn(getGlusterServers().get(0)).when(cmd).getUpServer();
Line 90: }
Line 91:
Line 92: private void mockBackend(boolean succeeded) {
--
To view, visit http://gerrit.ovirt.org/10906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc6f9c77393ebed2803ec2a1b295a09f61642c31
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
