Shireesh Anjal has posted comments on this change.

Change subject: engine: Enable gluster hook on cluster
......................................................................


Patch Set 19: (1 inline comment)

....................................................
File 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 590: GLUSTER_VOLUME_BRICK_REMOVED_FROM_CLI=Detected brick ${brick} removed 
from Volume ${glusterVolumeName} of cluster ${VdsGroupName}, and removed it 
from engine DB.
Line 591: GLUSTER_SERVER_REMOVED_FROM_CLI=Detected server ${VdsName} removed 
from Cluster ${VdsGroupName}, and removed it from engine DB.
Line 592: GLUSTER_VOLUME_STARTED_FROM_CLI=Detected that Volume 
${glusterVolumeName} of Cluster ${VdsGroupName} was started, and updated engine 
DB with it's new status.
Line 593: GLUSTER_VOLUME_STOPPED_FROM_CLI=Detected that Volume 
${glusterVolumeName} of Cluster ${VdsGroupName} was stopped, and updated engine 
DB with it's new status.
Line 594: GLUSTER_HOOK_ENABLE=Gluster Hook ${GlusterHookName} enabled.
I think it should work. Guess you'll find out during unit testing :)
If it works, I think GlusterHookCommandBase is a better place.


--
To view, visit http://gerrit.ovirt.org/10906
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc6f9c77393ebed2803ec2a1b295a09f61642c31
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to